Keep reference to DomainParticipantFactory
#770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiguelCompany
force-pushed
the
hotfix/keep-factory-shared-ptr
branch
from
8951c44
to
73f7936
Compare
rmw_fastrtps_shared_cpp/include/rmw_fastrtps_shared_cpp/custom_participant_info.hpp
Show resolved
Hide resolved
fujitatomoya
approved these changes
Jun 20, 2024
There was a problem hiding this comment.
@MiguelCompany thanks for the explanation, lgtm with green CI.
|
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
MiguelCompany
force-pushed
the
hotfix/keep-factory-shared-ptr
branch
from
73f7936
to
94cffad
Compare
|
@fujitatomoya @ahcorde I rebased this one to get the changes from #763 (I think the test failures were due to that) |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've seen several issues related with destruction order lately.
This PR aims to mitigate them by leveraging Fast DDS
DomainParticipantFactory::get_shared_instance().It should then avoid the automatic destruction of the factory (and the participants it created) until all the contexts in the process have been destroyed.
This can be backported to Jazzy and Iron, but not Humble, since
get_shared_instance()is only available from Fast DDS 2.8.0 onwards.